mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-117941: Reject option names starting with "--no-" in argparse.BooleanOptionalAction (GH-125894)

Browse source 
They never worked correctly.
This commit is contained in:
Serhiy Storchaka 2024-11-11 18:28:30 +02:00 • committed by GitHub
parent 819830f34a
commit 79805d2284
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/argparse.py
View file

@ -863,6 +863,9 @@ class BooleanOptionalAction(Action):
_option_strings.append(option_string)
if option_string.startswith('--'):
if option_string.startswith('--no-'):
raise ValueError(f'invalid option name {option_string!r} '
f'for BooleanOptionalAction')
option_string = '--no-' + option_string[2:]
_option_strings.append(option_string)