Closing transport during handshake process leaks socket (#480) (#2044)

This commit is contained in:
Yury Selivanov 2017-06-09 18:33:31 -04:00 committed by GitHub
parent d24429a20d
commit 7a16a4535d
3 changed files with 23 additions and 2 deletions

View file

@ -42,6 +42,7 @@ class SslProtoHandshakeTests(test_utils.TestCase):
sslpipe.do_handshake.side_effect = mock_handshake
with mock.patch('asyncio.sslproto._SSLPipe', return_value=sslpipe):
ssl_proto.connection_made(transport)
return transport
def test_cancel_handshake(self):
# Python issue #23197: cancelling a handshake must not raise an
@ -95,6 +96,20 @@ class SslProtoHandshakeTests(test_utils.TestCase):
test_utils.run_briefly(self.loop)
self.assertIsInstance(waiter.exception(), ConnectionAbortedError)
def test_close_during_handshake(self):
# bpo-29743 Closing transport during handshake process leaks socket
waiter = asyncio.Future(loop=self.loop)
ssl_proto = self.ssl_protocol(waiter)
def do_handshake(callback):
return []
transport = self.connection_made(ssl_proto)
test_utils.run_briefly(self.loop)
ssl_proto._app_transport.close()
self.assertTrue(transport.abort.called)
def test_get_extra_info_on_closed_connection(self):
waiter = asyncio.Future(loop=self.loop)
ssl_proto = self.ssl_protocol(waiter)