mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

bpo-32680 add default "sock" on SMTP objects (#5345)

Browse source 
By default the smtplib.SMTP objects did not have a sock attribute, it
was only created during connect()
This commit is contained in:
Romuald Brunet 2018-10-09 16:31:55 +02:00 • committed by Giampaolo Rodola
parent 2b2758d0b3
commit 7b31397180
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/test/test_smtplib.py
View file

@ -602,6 +602,13 @@ class NonConnectingTests(unittest.TestCase):
self.assertRaises(OSError, smtplib.SMTP,
"localhost:bogus")
def testSockAttributeExists(self):
# check that sock attribute is present outside of a connect() call
# (regression test, the previous behavior raised an
# AttributeError: 'SMTP' object has no attribute 'sock')
with smtplib.SMTP() as smtp:
self.assertIsNone(smtp.sock)
class DefaultArgumentsTests(unittest.TestCase):