mirror of
https://github.com/python/cpython.git
synced 2025-07-29 06:05:00 +00:00
Forward-port of r52136,52138: a review of overflow-detecting code.
* unified the way intobject, longobject and mystrtoul handle values around -sys.maxint-1. * in general, trying to entierely avoid overflows in any computation involving signed ints or longs is extremely involved. Fixed a few simple cases where a compiler might be too clever (but that's all guesswork). * more overflow checks against bad data in marshal.c. * 2.5 specific: fixed a number of places that were still confusing int and Py_ssize_t. Some of them could potentially have caused "real-world" breakage. * list.pop(x): fixing overflow issues on x was messy. I just reverted to PyArg_ParseTuple("n"), which does the right thing. (An obscure test was trying to give a Decimal to list.pop()... doesn't make sense any more IMHO) * trying to write a few tests...
This commit is contained in:
parent
0d2f498a4c
commit
7ccbca93a2
19 changed files with 186 additions and 106 deletions
|
@ -421,7 +421,7 @@ do_mkvalue(const char **p_format, va_list *p_va, int flags)
|
|||
"string too long for Python string");
|
||||
return NULL;
|
||||
}
|
||||
n = (int)m;
|
||||
n = (Py_ssize_t)m;
|
||||
}
|
||||
v = PyString_FromStringAndSize(str, n);
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue