mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 13:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Sf bug [ #412214 ] ZipFile constructor leaves files open.

Browse source 
This applies the patch Fred Drake created to fix it.
I'm checking it in since I had to apply the patch anyway in order
to test its behavior on Windows.
This commit is contained in:
Tim Peters 2001-04-04 18:56:49 +00:00
parent 42fc7ccdac
commit 7d3bad66e4
2 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Lib/test/test_zipfile.py
View file

@ -42,6 +42,22 @@ finally:
if os.path.isfile(zipname):
os.unlink(zipname)
# This test checks that the ZipFile constructor closes the file object
# it opens if there's an error in the file. If it doesn't, the traceback
# holds a reference to the ZipFile object and, indirectly, the file object.
# On Windows, this causes the os.unlink() call to fail because the
# underlying file is still open. This is SF bug #412214.
#
fp = open(srcname, "w")
fp.write("this is not a legal zip file\n")
fp.close()
try:
zf = zipfile.ZipFile(srcname)
except zipfile.BadZipfile:
os.unlink(srcname)
# make sure we don't raise an AttributeError when a partially-constructed
# ZipFile instance is finalized; this tests for regression on SF tracker
# bug #403871.