mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

gh-120868: Fix breaking change in logging.config when using QueueHandler (GH-120872)

Browse source
This commit is contained in:
Janek Nouvertné 2024-06-27 09:09:01 +02:00 • committed by GitHub
parent 4be1f37b20
commit 7d9c68513d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 81 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Lib/test/test_logging.py
View file

@ -3928,6 +3928,50 @@ class ConfigDictTest(BaseTest):
msg = str(ctx.exception)
self.assertEqual(msg, "Unable to configure handler 'ah'")
@threading_helper.requires_working_threading()
@support.requires_subprocess()
@patch("multiprocessing.Manager")
def test_config_queue_handler_does_not_create_multiprocessing_manager(self, manager):
# gh-120868
from multiprocessing import Queue as MQ
q1 = {"()": "queue.Queue", "maxsize": -1}
q2 = MQ()
q3 = queue.Queue()
for qspec in (q1, q2, q3):
self.apply_config(
{
"version": 1,
"handlers": {
"queue_listener": {
"class": "logging.handlers.QueueHandler",
"queue": qspec,
},
},
}
)
manager.assert_not_called()
@patch("multiprocessing.Manager")
def test_config_queue_handler_invalid_config_does_not_create_multiprocessing_manager(self, manager):
# gh-120868
with self.assertRaises(ValueError):
self.apply_config(
{
"version": 1,
"handlers": {
"queue_listener": {
"class": "logging.handlers.QueueHandler",
"queue": object(),
},
},
}
)
manager.assert_not_called()
@support.requires_subprocess()
def test_multiprocessing_queues(self):
# See gh-119819