mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-01 15:43:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Prevent expandtabs() on string and unicode objects from causing a segfault when

Browse source 
a large width is passed on 32-bit platforms.  Found by Google.

It would be good for people to review this especially carefully and verify
I don't have an off by one error and there is no other way to cause overflow.
This commit is contained in:
Neal Norwitz 2007-06-09 03:36:34 +00:00
parent ea7f88e3d9
commit 7dbd2a3720
5 changed files with 49 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/test_unicode.py
View file

@ -817,8 +817,13 @@ class UnicodeTest(
self.assertEqual(repr(s1()), '\\n')
self.assertEqual(repr(s2()), '\\n')
def test_expandtabs_overflows_gracefully(self):
# This test only affects 32-bit platforms because expandtabs can only take
# an int as the max value, not a 64-bit C long. If expandtabs is changed
# to take a 64-bit long, this test should apply to all platforms.
if sys.maxint > (1 << 32):
return
self.assertRaises(OverflowError, u't\tt\t'.expandtabs, sys.maxint)
def test_main():