mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-26 13:22:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

gh-99537: Use Py_SETREF() function in C code (#99656)

Browse source 
Fix potential race condition in code patterns:

* Replace "Py_DECREF(var); var = new;" with "Py_SETREF(var, new);"
* Replace "Py_XDECREF(var); var = new;" with "Py_XSETREF(var, new);"
* Replace "Py_CLEAR(var); var = new;" with "Py_XSETREF(var, new);"

Other changes:

* Replace "old = var; var = new; Py_DECREF(var)"
  with "Py_SETREF(var, new);"
* Replace "old = var; var = new; Py_XDECREF(var)"
  with "Py_XSETREF(var, new);"
* And remove the "old" variable.
This commit is contained in:
Victor Stinner 2022-11-22 14:22:22 +01:00 • committed by GitHub
parent 135ec7cefb
commit 7e3f09cad9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 37 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Modules/_json.c
View file

@ -709,9 +709,7 @@ _parse_object_unicode(PyScannerObject *s, PyObject *pystr, Py_ssize_t idx, Py_ss
if (memokey == NULL) {
goto bail;
}
Py_INCREF(memokey);
Py_DECREF(key);
key = memokey;
Py_SETREF(key, Py_NewRef(memokey));
idx = next_idx;
/* skip whitespace between key and : delimiter, read :, skip whitespace */