gh-116436: Improve error message when TypeError occurs during dict update (#116443)

This commit is contained in:
Shantanu 2025-04-29 22:18:06 -07:00 committed by GitHub
parent 4e294f6feb
commit 7e8b153fef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 31 additions and 4 deletions

View file

@ -266,6 +266,31 @@ class DictTest(unittest.TestCase):
self.assertRaises(ValueError, {}.update, [(1, 2, 3)])
def test_update_type_error(self):
with self.assertRaises(TypeError) as cm:
{}.update([object() for _ in range(3)])
self.assertEqual(str(cm.exception), "object is not iterable")
self.assertEqual(
cm.exception.__notes__,
['Cannot convert dictionary update sequence element #0 to a sequence'],
)
def badgen():
yield "key"
raise TypeError("oops")
yield "value"
with self.assertRaises(TypeError) as cm:
dict([badgen() for _ in range(3)])
self.assertEqual(str(cm.exception), "oops")
self.assertEqual(
cm.exception.__notes__,
['Cannot convert dictionary update sequence element #0 to a sequence'],
)
def test_fromkeys(self):
self.assertEqual(dict.fromkeys('abc'), {'a':None, 'b':None, 'c':None})
d = {}