mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 13:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

GH-127381: pathlib ABCs: remove PathBase.unlink() and rmdir() (#127736)

Browse source 
Virtual filesystems don't always make a distinction between deleting files
and empty directories, and sometimes support deleting non-empty directories
in a single operation. Here we remove `PathBase.unlink()` and `rmdir()`,
leaving `_delete()` as the sole deletion method, now made abstract. I hope
to drop the underscore prefix later on.
This commit is contained in:
Barney Gale 2024-12-08 18:45:09 +00:00 • committed by GitHub
parent 2367759212
commit 7f8ec52302
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 48 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Lib/test/test_pathlib/test_pathlib.py
View file

@ -1352,6 +1352,25 @@ class PathTest(test_pathlib_abc.DummyPathTest, PurePathTest):
self.assertEqual(expected_gid, gid_2)
self.assertEqual(expected_name, link.group(follow_symlinks=False))
def test_unlink(self):
p = self.cls(self.base) / 'fileA'
p.unlink()
self.assertFileNotFound(p.stat)
self.assertFileNotFound(p.unlink)
def test_unlink_missing_ok(self):
p = self.cls(self.base) / 'fileAAA'
self.assertFileNotFound(p.unlink)
p.unlink(missing_ok=True)
def test_rmdir(self):
p = self.cls(self.base) / 'dirA'
for q in p.iterdir():
q.unlink()
p.rmdir()
self.assertFileNotFound(p.stat)
self.assertFileNotFound(p.unlink)
@needs_symlinks
def test_delete_symlink(self):
tmp = self.cls(self.base, 'delete')