mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-07 11:25:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-132685: fix thread safety of PyMember_GetOne with _Py_T_OBJECT (#132690)

Browse source
This commit is contained in:
Kumar Aditya 2025-04-18 21:03:42 +05:30 • committed by GitHub
parent e77d6784e7
commit 7fd708b727
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Python/structmember.c
View file

@ -85,10 +85,22 @@ PyMember_GetOne(const char *obj_addr, PyMemberDef *l)
break;
}
case _Py_T_OBJECT:
v = *(PyObject **)addr;
if (v == NULL)
v = FT_ATOMIC_LOAD_PTR(*(PyObject **) addr);
if (v != NULL) {
#ifdef Py_GIL_DISABLED
if (!_Py_TryIncrefCompare((PyObject **) addr, v)) {
Py_BEGIN_CRITICAL_SECTION((PyObject *) obj_addr);
v = FT_ATOMIC_LOAD_PTR(*(PyObject **) addr);
Py_XINCREF(v);
Py_END_CRITICAL_SECTION();
}
#else
Py_INCREF(v);
#endif
}
if (v == NULL) {
v = Py_None;
Py_INCREF(v);
}
break;
case Py_T_OBJECT_EX:
v = member_get_object(addr, obj_addr, l);