mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (#5240)

Browse source 
Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
This commit is contained in:
Zackery Spytz 2018-02-20 14:06:11 -07:00 • committed by Serhiy Storchaka
parent 7a1e1786f9
commit 80d20b918b
4 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_aifc.py
View file

@ -266,6 +266,14 @@ class AIFCLowLevelTest(unittest.TestCase):
b = io.BytesIO(b'FORM' + struct.pack('>L', 4) + b'AIFF')
self.assertRaises(aifc.Error, aifc.open, b)
def test_read_no_ssnd_chunk(self):
b = b'FORM' + struct.pack('>L', 4) + b'AIFC'
b += b'COMM' + struct.pack('>LhlhhLL', 38, 0, 0, 0, 0, 0, 0)
b += b'NONE' + struct.pack('B', 14) + b'not compressed' + b'\x00'
with self.assertRaisesRegex(aifc.Error, 'COMM chunk and/or SSND chunk'
' missing'):
aifc.open(io.BytesIO(b))
def test_read_wrong_compression_type(self):
b = b'FORM' + struct.pack('>L', 4) + b'AIFC'
b += b'COMM' + struct.pack('>LhlhhLL', 23, 0, 0, 0, 0, 0, 0)