mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 10:19:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #7079: Fix a possible crash when closing a file object while using

Browse source 
it from another thread.  Patch by Daniel Stutzbach.
This commit is contained in:
Antoine Pitrou 2010-05-17 19:56:59 +00:00
parent af87f9f09f
commit 83137c2e16
3 changed files with 18 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/test/test_file2k.py
View file

@ -429,6 +429,7 @@ class FileThreadingTests(unittest.TestCase):
self._count_lock = threading.Lock()
self.close_count = 0
self.close_success_count = 0
self.use_buffering = False
def tearDown(self):
if self.f:
@ -443,7 +444,10 @@ class FileThreadingTests(unittest.TestCase):
test_support.threading_cleanup(*self._threads)
def _create_file(self):
self.f = open(self.filename, "w+")
if self.use_buffering:
self.f = open(self.filename, "w+", buffering=1024*16)
else:
self.f = open(self.filename, "w+")
def _close_file(self):
with self._count_lock:
@ -530,6 +534,12 @@ class FileThreadingTests(unittest.TestCase):
print >> self.f, ''
self._test_close_open_io(io_func)
def test_close_open_print_buffered(self):
self.use_buffering = True
def io_func():
print >> self.f, ''
self._test_close_open_io(io_func)
def test_close_open_read(self):
def io_func():
self.f.read(0)