mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

bpo-36719: Fix regrtest re-run (GH-12964)

Browse source 
Properly handle a test which fail but then pass.

Add test_rerun_success() unit test.
This commit is contained in:
Victor Stinner 2019-04-26 09:56:37 +02:00 • committed by GitHub
parent 75120d2205
commit 837acc1957
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Lib/test/test_regrtest.py
View file

@ -484,7 +484,7 @@ class BaseTestCase(unittest.TestCase):
result.append('SUCCESS')
result = ', '.join(result)
if rerun:
self.check_line(output, 'Tests result: %s' % result)
self.check_line(output, 'Tests result: FAILURE')
result = 'FAILURE then %s' % result
self.check_line(output, 'Tests result: %s' % result)
@ -989,6 +989,7 @@ class ArgsTestCase(BaseTestCase):
fail_env_changed=True)
def test_rerun_fail(self):
# FAILURE then FAILURE
code = textwrap.dedent("""
import unittest
@ -1003,6 +1004,26 @@ class ArgsTestCase(BaseTestCase):
self.check_executed_tests(output, [testname],
failed=testname, rerun=testname)
def test_rerun_success(self):
# FAILURE then SUCCESS
code = textwrap.dedent("""
import builtins
import unittest
class Tests(unittest.TestCase):
failed = False
def test_fail_once(self):
if not hasattr(builtins, '_test_failed'):
builtins._test_failed = True
self.fail("bug")
""")
testname = self.create_test(code=code)
output = self.run_tests("-w", testname, exitcode=0)
self.check_executed_tests(output, [testname],
rerun=testname)
def test_no_tests_ran(self):
code = textwrap.dedent("""
import unittest