Fixed memory leak on failure. This is related to issue5403 but won't crash on py3k.

This commit is contained in:
Hirokazu Yamamoto 2009-03-03 07:49:01 +00:00
parent 45ed72ddaf
commit 8404749e4b
4 changed files with 38 additions and 8 deletions

View file

@ -526,18 +526,23 @@ MD5_new(PyObject *self, PyObject *args, PyObject *kwdict)
if (data_obj)
GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf);
if ((new = newMD5object()) == NULL)
if ((new = newMD5object()) == NULL) {
if (data_obj)
PyBuffer_Release(&buf);
return NULL;
}
md5_init(&new->hash_state);
if (PyErr_Occurred()) {
Py_DECREF(new);
if (data_obj)
PyBuffer_Release(&buf);
return NULL;
}
if (data_obj) {
md5_process(&new->hash_state, buf.buf, buf.len);
PyBuffer_Release(&buf);
PyBuffer_Release(&buf);
}
return (PyObject *)new;