mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

bpo-31247: xmlrpc.server: break reference cycle (#3166)

Browse source 
xmlrpc.server now explicitly breaks reference cycles when using
sys.exc_info() in code handling exceptions.
This commit is contained in:
Victor Stinner 2017-08-21 18:12:58 +02:00 • committed by GitHub
parent f432a3234f
commit 84524454d0
2 changed files with 26 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Lib/xmlrpc/server.py
View file

@ -270,10 +270,14 @@ class SimpleXMLRPCDispatcher:
except: except:
# report exception back to server # report exception back to server
exc_type, exc_value, exc_tb = sys.exc_info() exc_type, exc_value, exc_tb = sys.exc_info()
try:
response = dumps( response = dumps(
Fault(1, "%s:%s" % (exc_type, exc_value)), Fault(1, "%s:%s" % (exc_type, exc_value)),
encoding=self.encoding, allow_none=self.allow_none, encoding=self.encoding, allow_none=self.allow_none,
) )
finally:
# Break reference cycle
exc_type = exc_value = exc_tb = None
return response.encode(self.encoding, 'xmlcharrefreplace') return response.encode(self.encoding, 'xmlcharrefreplace')
@ -365,10 +369,14 @@ class SimpleXMLRPCDispatcher:
) )
except: except:
exc_type, exc_value, exc_tb = sys.exc_info() exc_type, exc_value, exc_tb = sys.exc_info()
try:
results.append( results.append(
{'faultCode' : 1, {'faultCode' : 1,
'faultString' : "%s:%s" % (exc_type, exc_value)} 'faultString' : "%s:%s" % (exc_type, exc_value)}
) )
finally:
# Break reference cycle
exc_type = exc_value = exc_tb = None
return results return results
def _dispatch(self, method, params): def _dispatch(self, method, params):
@ -630,10 +638,14 @@ class MultiPathXMLRPCServer(SimpleXMLRPCServer):
# (each dispatcher should have handled their own # (each dispatcher should have handled their own
# exceptions) # exceptions)
exc_type, exc_value = sys.exc_info()[:2] exc_type, exc_value = sys.exc_info()[:2]
try:
response = dumps( response = dumps(
Fault(1, "%s:%s" % (exc_type, exc_value)), Fault(1, "%s:%s" % (exc_type, exc_value)),
encoding=self.encoding, allow_none=self.allow_none) encoding=self.encoding, allow_none=self.allow_none)
response = response.encode(self.encoding, 'xmlcharrefreplace') response = response.encode(self.encoding, 'xmlcharrefreplace')
finally:
# Break reference cycle
exc_type = exc_value = None
return response return response
class CGIXMLRPCRequestHandler(SimpleXMLRPCDispatcher): class CGIXMLRPCRequestHandler(SimpleXMLRPCDispatcher):

2
Misc/NEWS.d/next/Library/2017-08-21-17-50-27.bpo-31247.8S3zJp.rst Normal file
View file

@ -0,0 +1,2 @@
xmlrpc.server now explicitly breaks reference cycles when using
sys.exc_info() in code handling exceptions.