SF bug 130030: Claim of bad betavariate algorithm.

Lib/random.py

@@ -461,14 +461,27 @@ class Random:
         return mu + z*sigma
 
 ## -------------------- beta --------------------
+## See
+## http://sourceforge.net/bugs/?func=detailbug&bug_id=130030&group_id=5470
+## for Ivan Frohne's insightful analysis of why the original implementation:
+##
+##    def betavariate(self, alpha, beta):
+##        # Discrete Event Simulation in C, pp 87-88.
+##
+##        y = self.expovariate(alpha)
+##        z = self.expovariate(1.0/beta)
+##        return z/(y+z)
+##
+## was dead wrong, and how it probably got that way.
 
     def betavariate(self, alpha, beta):
-
+        # This version due to Janne Sinkkonen, and matches all the std
-        # Discrete Event Simulation in C, pp 87-88.
+        # texts (e.g., Knuth Vol 2 Ed 3 pg 134 "the beta distribution").
-
+        y = self.gammavariate(alpha, 1.)
-        y = self.expovariate(alpha)
+        if y == 0:
-        z = self.expovariate(1.0/beta)
+            return 0.0
-        return z/(y+z)
+        else:
+            return y / (y + self.gammavariate(beta, 1.))
 
 ## -------------------- Pareto --------------------
 

Misc/ACKS

@@ -118,7 +118,7 @@ Sebastian Fernandez
 Nils Fischbeck
 Doug Fort
 Robin Friedrich
-Ivan Frohe
+Ivan Frohne
 Jim Fulton
 Geoff Furnish
 Tadayoshi Funaba
@@ -338,6 +338,7 @@ Joel Shprentz
 Eric Siegerman
 Paul Sijben
 Nathan Paul Simons
+Janne Sinkkonen
 George Sipe
 Kragen Sitaker
 Rafal Smotrzyk