mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-11 19:40:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-103300: Fix Popen.wait() deadlock in patchcheck.py (#103301)

Browse source
This commit is contained in:
Oleg Iarygin 2023-04-09 12:18:53 +04:00 • committed by GitHub
parent d9305f8e9d
commit 86d2044155
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Tools/patchcheck/patchcheck.py
View file

@ -130,9 +130,10 @@ def changed_files(base_branch=None):
with subprocess.Popen(cmd.split(), with subprocess.Popen(cmd.split(),
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
cwd=SRCDIR) as st: cwd=SRCDIR) as st:
if st.wait() != 0: git_file_status, _ = st.communicate()
if st.returncode != 0:
sys.exit(f'error running {cmd}') sys.exit(f'error running {cmd}')
for line in st.stdout: for line in git_file_status.splitlines():
line = line.decode().rstrip() line = line.decode().rstrip()
status_text, filename = line.split(maxsplit=1) status_text, filename = line.split(maxsplit=1)
status = set(status_text) status = set(status_text)