mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 21:48:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Close #12085: Fix an attribute error in subprocess.Popen destructor if the

Browse source 
constructor has failed, e.g. because of an undeclared keyword argument. Patch
written by Oleg Oshmyan.
This commit is contained in:
Victor Stinner 2011-06-01 00:57:47 +02:00
parent ee49797c8d
commit 87b9bc3893
4 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_subprocess.py
View file

@ -121,6 +121,16 @@ class ProcessTestCase(BaseTestCase):
env=newenv)
self.assertEqual(rc, 1)
def test_invalid_args(self):
# Popen() called with invalid arguments should raise TypeError
# but Popen.__del__ should not complain (issue #12085)
with support.captured_stderr() as s:
self.assertRaises(TypeError, subprocess.Popen, invalid_arg_name=1)
argcount = subprocess.Popen.__init__.__code__.co_argcount
too_many_args = [0] * (argcount + 1)
self.assertRaises(TypeError, subprocess.Popen, *too_many_args)
self.assertEqual(s.getvalue(), '')
def test_stdin_none(self):
# .stdin is None when not redirected
p = subprocess.Popen([sys.executable, "-c", 'print("banana")'],