mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 19:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

[3.13] gh-128152: Argument Clinic: ignore pre-processor directives inside C comments (GH-128464) (#128478)

Browse source 
(cherry picked from commit a4e773c540)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
This commit is contained in:
Miss Islington (bot) 2025-01-04 12:09:25 +01:00 • committed by GitHub
parent 855af3bbc6
commit 883cb23dd1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_clinic.py
View file

@ -731,6 +731,16 @@ class ClinicWholeFileTest(TestCase):
err = "Cannot use @text_signature when cloning a function" err = "Cannot use @text_signature when cloning a function"
self.expect_failure(block, err, lineno=11) self.expect_failure(block, err, lineno=11)
def test_ignore_preprocessor_in_comments(self):
for dsl in "clinic", "python":
raw = dedent(f"""\
/*[{dsl} input]
# CPP directives, valid or not, should be ignored in C comments.
#
[{dsl} start generated code]*/
""")
self.clinic.parse(raw)
class ParseFileUnitTest(TestCase): class ParseFileUnitTest(TestCase):
def expect_parsing_failure( def expect_parsing_failure(

2
Misc/NEWS.d/next/Tools-Demos/2025-01-03-23-51-07.gh-issue-128152.IhzElS.rst Normal file
View file

@ -0,0 +1,2 @@
Fix a bug where Argument Clinic's C pre-processor parser tried to parse
pre-processor directives inside C comments. Patch by Erlend Aasland.

3
Tools/clinic/libclinic/cpp.py
View file

@ -132,6 +132,9 @@ class Monitor:
if line_comment: if line_comment:
line = before.rstrip() line = before.rstrip()
if self.in_comment:
return
if not line.startswith('#'): if not line.startswith('#'):
return return