From 89ba660717a890359c2f50e74a711daf037ef70d Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Fri, 24 Jun 2022 11:54:47 -0700 Subject: [PATCH] gh-94217: Skip import tests when _testcapi is a builtin (GH-94218) (cherry picked from commit 0a40025b803a8dc1d604538e317992827ab96625) Co-authored-by: Christian Heimes --- Lib/test/test_importlib/extension/test_finder.py | 6 +++++- Lib/test/test_importlib/extension/test_loader.py | 8 ++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_importlib/extension/test_finder.py b/Lib/test/test_importlib/extension/test_finder.py index b6663a44845..1d5b6e7a5de 100644 --- a/Lib/test/test_importlib/extension/test_finder.py +++ b/Lib/test/test_importlib/extension/test_finder.py @@ -3,7 +3,7 @@ from test.test_importlib import abc, util machinery = util.import_importlib('importlib.machinery') import unittest -import warnings +import sys class FinderTests(abc.FinderTests): @@ -13,6 +13,10 @@ class FinderTests(abc.FinderTests): def setUp(self): if not self.machinery.EXTENSION_SUFFIXES: raise unittest.SkipTest("Requires dynamic loading support.") + if util.EXTENSIONS.name in sys.builtin_module_names: + raise unittest.SkipTest( + f"{util.EXTENSIONS.name} is a builtin module" + ) def find_spec(self, fullname): importer = self.machinery.FileFinder(util.EXTENSIONS.path, diff --git a/Lib/test/test_importlib/extension/test_loader.py b/Lib/test/test_importlib/extension/test_loader.py index 5080009bee3..8570c6bc90c 100644 --- a/Lib/test/test_importlib/extension/test_loader.py +++ b/Lib/test/test_importlib/extension/test_loader.py @@ -20,6 +20,10 @@ class LoaderTests(abc.LoaderTests): def setUp(self): if not self.machinery.EXTENSION_SUFFIXES: raise unittest.SkipTest("Requires dynamic loading support.") + if util.EXTENSIONS.name in sys.builtin_module_names: + raise unittest.SkipTest( + f"{util.EXTENSIONS.name} is a builtin module" + ) self.loader = self.machinery.ExtensionFileLoader(util.EXTENSIONS.name, util.EXTENSIONS.file_path) @@ -97,6 +101,10 @@ class MultiPhaseExtensionModuleTests(abc.LoaderTests): if not self.machinery.EXTENSION_SUFFIXES: raise unittest.SkipTest("Requires dynamic loading support.") self.name = '_testmultiphase' + if self.name in sys.builtin_module_names: + raise unittest.SkipTest( + f"{self.name} is a builtin module" + ) finder = self.machinery.FileFinder(None) self.spec = importlib.util.find_spec(self.name) assert self.spec