mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-132781: Make NotShareableError a TypeError Subclass (gh-132973)

Browse source 
It was a subclass of ValueError. However, shareability is a feature of types, not values.
This commit is contained in:
Eric Snow 2025-04-25 15:10:43 -06:00 • committed by GitHub
parent cd9536a087
commit 8a4d4f37ab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Python/crossinterp_exceptions.h
View file

@ -46,14 +46,13 @@ static PyTypeObject _PyExc_InterpreterNotFoundError = {
}; };
PyObject *PyExc_InterpreterNotFoundError = (PyObject *)&_PyExc_InterpreterNotFoundError; PyObject *PyExc_InterpreterNotFoundError = (PyObject *)&_PyExc_InterpreterNotFoundError;
/* NotShareableError extends ValueError */ /* NotShareableError extends TypeError */
static int static int
_init_notshareableerror(exceptions_t *state) _init_notshareableerror(exceptions_t *state)
{ {
const char *name = "interpreters.NotShareableError"; const char *name = "interpreters.NotShareableError";
// XXX Inherit from TypeError. PyObject *base = PyExc_TypeError;
PyObject *base = PyExc_ValueError;
PyObject *ns = NULL; PyObject *ns = NULL;
PyObject *exctype = PyErr_NewException(name, base, ns); PyObject *exctype = PyErr_NewException(name, base, ns);
if (exctype == NULL) { if (exctype == NULL) {
@ -94,7 +93,7 @@ _ensure_notshareableerror(PyThreadState *tstate,
} }
} }
else { else {
exctype = PyExc_ValueError; exctype = PyExc_TypeError;
} }
_PyErr_SetObject(tstate, exctype, msgobj); _PyErr_SetObject(tstate, exctype, msgobj);
// We have to set the context manually since _PyErr_SetObject() doesn't. // We have to set the context manually since _PyErr_SetObject() doesn't.