mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

bpo-30876: Relative import from unloaded package now reimports the package (#2639)

Browse source 
instead of failing with SystemError.

Relative import from non-package now fails with ImportError rather than
SystemError.
This commit is contained in:
Serhiy Storchaka 2017-07-12 06:50:03 +03:00 • committed by GitHub
parent 6d13b22e3a
commit 8a9cd20edc
8 changed files with 390 additions and 388 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Python/import.c
View file

@ -1344,7 +1344,6 @@ resolve_name(PyObject *name, PyObject *globals, int level)
PyObject *abs_name;
PyObject *package = NULL;
PyObject *spec;
PyInterpreterState *interp = PyThreadState_GET()->interp;
Py_ssize_t last_dot;
PyObject *base;
int level_up;
@ -1448,12 +1447,6 @@ resolve_name(PyObject *name, PyObject *globals, int level)
"attempted relative import with no known parent package");
goto error;
}
else if (PyDict_GetItem(interp->modules, package) == NULL) {
PyErr_Format(PyExc_SystemError,
"Parent module %R not loaded, cannot perform relative "
"import", package);
goto error;
}
for (level_up = 1; level_up < level; level_up += 1) {
last_dot = PyUnicode_FindChar(package, '.', 0, last_dot, -1);