mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Issue #23524: Change back to using Windows errors for _Py_fstat instead of the errno shim.

Browse source
This commit is contained in:
Steve Dower 2015-03-07 18:14:07 -08:00
parent 35a97c0bed
commit 8acde7dcce
3 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Python/fileutils.c
View file

@ -637,10 +637,14 @@ _Py_fstat(int fd, struct _Py_stat_struct *result)
else
h = (HANDLE)_get_osfhandle(fd);
/* Protocol violation: we explicitly clear errno, instead of
setting it to a POSIX error. Callers should use GetLastError. */
errno = 0;
if (h == INVALID_HANDLE_VALUE) {
errno = EBADF;
/* This is really a C library error (invalid file handle).
We set the Win32 error to the closes one matching. */
SetLastError(ERROR_INVALID_HANDLE);
return -1;
}
memset(result, 0, sizeof(*result));
@ -649,7 +653,6 @@ _Py_fstat(int fd, struct _Py_stat_struct *result)
if (type == FILE_TYPE_UNKNOWN) {
DWORD error = GetLastError();
if (error != 0) {
errno = EINVAL;
return -1;
}
/* else: valid but unknown file */
@ -664,7 +667,6 @@ _Py_fstat(int fd, struct _Py_stat_struct *result)
}
if (!GetFileInformationByHandle(h, &info)) {
errno = EINVAL;
return -1;
}