mirror of
https://github.com/python/cpython.git
synced 2025-11-25 04:34:37 +00:00
Fixing #1531862: Do not close standard file descriptors in the
subprocess module.
This commit is contained in:
parent
b15a0ccf6d
commit
8cb64eaaf3
3 changed files with 48 additions and 8 deletions
|
|
@ -1000,14 +1000,10 @@ class Popen(object):
|
|||
if errwrite:
|
||||
os.dup2(errwrite, 2)
|
||||
|
||||
# Close pipe fds. Make sure we doesn't close the same
|
||||
# fd more than once.
|
||||
if p2cread:
|
||||
os.close(p2cread)
|
||||
if c2pwrite and c2pwrite not in (p2cread,):
|
||||
os.close(c2pwrite)
|
||||
if errwrite and errwrite not in (p2cread, c2pwrite):
|
||||
os.close(errwrite)
|
||||
# Close pipe fds. Make sure we don't close the same
|
||||
# fd more than once, or standard fds.
|
||||
for fd in set((p2cread, c2pwrite, errwrite))-set((0,1,2)):
|
||||
if fd: os.close(fd)
|
||||
|
||||
# Close all other fds, if asked for
|
||||
if close_fds:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue