mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 13:38:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-118473: Fix set_asyncgen_hooks not to be partially set when arguments are invalid (#118474)

Browse source
This commit is contained in:
Jeong, YunWon 2024-05-07 09:02:52 +09:00 • committed by GitHub
parent e272195b3e
commit 8d8275b0cf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 36 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Python/sysmodule.c
View file

@ -1399,12 +1399,6 @@ sys_set_asyncgen_hooks(PyObject *self, PyObject *args, PyObject *kw)
Py_TYPE(finalizer)->tp_name);
return NULL;
}
if (_PyEval_SetAsyncGenFinalizer(finalizer) < 0) {
return NULL;
}
}
else if (finalizer == Py_None && _PyEval_SetAsyncGenFinalizer(NULL) < 0) {
return NULL;
}
if (firstiter && firstiter != Py_None) {
@ -1414,15 +1408,33 @@ sys_set_asyncgen_hooks(PyObject *self, PyObject *args, PyObject *kw)
Py_TYPE(firstiter)->tp_name);
return NULL;
}
if (_PyEval_SetAsyncGenFirstiter(firstiter) < 0) {
}
PyObject *cur_finalizer = _PyEval_GetAsyncGenFinalizer();
if (finalizer && finalizer != Py_None) {
if (_PyEval_SetAsyncGenFinalizer(finalizer) < 0) {
return NULL;
}
}
else if (firstiter == Py_None && _PyEval_SetAsyncGenFirstiter(NULL) < 0) {
else if (finalizer == Py_None && _PyEval_SetAsyncGenFinalizer(NULL) < 0) {
return NULL;
}
if (firstiter && firstiter != Py_None) {
if (_PyEval_SetAsyncGenFirstiter(firstiter) < 0) {
goto error;
}
}
else if (firstiter == Py_None && _PyEval_SetAsyncGenFirstiter(NULL) < 0) {
goto error;
}
Py_RETURN_NONE;
error:
_PyEval_SetAsyncGenFinalizer(cur_finalizer);
return NULL;
}
PyDoc_STRVAR(set_asyncgen_hooks_doc,