mirror of
https://github.com/python/cpython.git
synced 2025-08-04 17:08:35 +00:00
[3.13] gh-128231: Use runcode()
return value for failing early (GH-129488) (#130513)
gh-128231: Use `runcode()` return value for failing early (GH-129488)
(cherry picked from commit 7ed3dc6392
)
Co-authored-by: Bartosz Sławecki <bartoszpiotrslawecki@gmail.com>
This commit is contained in:
parent
2ccb84a871
commit
8f6a9aa6ae
5 changed files with 40 additions and 3 deletions
|
@ -153,6 +153,8 @@ class Console(ABC):
|
|||
|
||||
|
||||
class InteractiveColoredConsole(code.InteractiveConsole):
|
||||
STATEMENT_FAILED = object()
|
||||
|
||||
def __init__(
|
||||
self,
|
||||
locals: dict[str, object] | None = None,
|
||||
|
@ -174,6 +176,16 @@ class InteractiveColoredConsole(code.InteractiveConsole):
|
|||
limit=traceback.BUILTIN_EXCEPTION_LIMIT)
|
||||
self.write(''.join(lines))
|
||||
|
||||
def runcode(self, code):
|
||||
try:
|
||||
exec(code, self.locals)
|
||||
except SystemExit:
|
||||
raise
|
||||
except BaseException:
|
||||
self.showtraceback()
|
||||
return self.STATEMENT_FAILED
|
||||
return None
|
||||
|
||||
def runsource(self, source, filename="<input>", symbol="single"):
|
||||
try:
|
||||
tree = self.compile.compiler(
|
||||
|
@ -211,5 +223,7 @@ class InteractiveColoredConsole(code.InteractiveConsole):
|
|||
if code is None:
|
||||
return True
|
||||
|
||||
self.runcode(code)
|
||||
result = self.runcode(code)
|
||||
if result is self.STATEMENT_FAILED:
|
||||
break
|
||||
return False
|
||||
|
|
|
@ -75,7 +75,7 @@ class AsyncIOInteractiveConsole(InteractiveColoredConsole):
|
|||
self.write("\nKeyboardInterrupt\n")
|
||||
else:
|
||||
self.showtraceback()
|
||||
|
||||
return self.STATEMENT_FAILED
|
||||
|
||||
class REPLThread(threading.Thread):
|
||||
|
||||
|
|
|
@ -53,6 +53,19 @@ class TestSimpleInteract(unittest.TestCase):
|
|||
self.assertFalse(more)
|
||||
self.assertEqual(f.getvalue(), "1\n")
|
||||
|
||||
@force_not_colorized
|
||||
def test_multiple_statements_fail_early(self):
|
||||
console = InteractiveColoredConsole()
|
||||
code = dedent("""\
|
||||
raise Exception('foobar')
|
||||
print('spam&eggs')
|
||||
""")
|
||||
f = io.StringIO()
|
||||
with contextlib.redirect_stderr(f):
|
||||
console.runsource(code)
|
||||
self.assertIn('Exception: foobar', f.getvalue())
|
||||
self.assertNotIn('spam&eggs', f.getvalue())
|
||||
|
||||
def test_empty(self):
|
||||
namespace = {}
|
||||
code = ""
|
||||
|
|
|
@ -294,7 +294,15 @@ class TestInteractiveModeSyntaxErrors(unittest.TestCase):
|
|||
self.assertEqual(traceback_lines, expected_lines)
|
||||
|
||||
|
||||
class TestAsyncioREPLContextVars(unittest.TestCase):
|
||||
class TestAsyncioREPL(unittest.TestCase):
|
||||
def test_multiple_statements_fail_early(self):
|
||||
user_input = "1 / 0; print('afterwards')"
|
||||
p = spawn_repl("-m", "asyncio")
|
||||
p.stdin.write(user_input)
|
||||
output = kill_python(p)
|
||||
self.assertIn("ZeroDivisionError", output)
|
||||
self.assertNotIn("afterwards", output)
|
||||
|
||||
def test_toplevel_contextvars_sync(self):
|
||||
user_input = dedent("""\
|
||||
from contextvars import ContextVar
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
Execution of multiple statements in the new REPL now stops immediately upon
|
||||
the first exception encountered. Patch by Bartosz Sławecki.
|
Loading…
Add table
Add a link
Reference in a new issue