mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

#10777: fix iteration over dict keys while mutating the dict.

Browse source
This commit is contained in:
Georg Brandl 2010-12-28 10:38:33 +00:00
parent ff52f76019
commit 90b20675bd
3 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/test_xml_etree.py
View file

@ -1841,6 +1841,15 @@ def check_issue6565():
""" """
def check_issue10777():
"""
Registering a namespace twice caused a "dictionary changed size during
iteration" bug.
>>> ET.register_namespace('test10777', 'http://myuri/')
>>> ET.register_namespace('test10777', 'http://myuri/')
"""
# -------------------------------------------------------------------- # --------------------------------------------------------------------

2
Lib/xml/etree/ElementTree.py
View file

@ -1068,7 +1068,7 @@ _serialize = {
def register_namespace(prefix, uri): def register_namespace(prefix, uri):
if re.match("ns\d+$", prefix): if re.match("ns\d+$", prefix):
raise ValueError("Prefix format reserved for internal use") raise ValueError("Prefix format reserved for internal use")
for k, v in _namespace_map.items(): for k, v in list(_namespace_map.items()):
if k == uri or v == prefix: if k == uri or v == prefix:
del _namespace_map[k] del _namespace_map[k]
_namespace_map[uri] = prefix _namespace_map[uri] = prefix

3
Misc/NEWS
View file

@ -18,6 +18,9 @@ Core and Builtins
Library Library
------- -------
- Issue #10777: Fix "dictionary changed size during iteration" bug in
ElementTree register_namespace().
- Issue #10626: test_logging now preserves logger disabled states. - Issue #10626: test_logging now preserves logger disabled states.
- Issue #10774: test_logging now removes temp files created during tests. - Issue #10774: test_logging now removes temp files created during tests.