mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-04 00:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

urllib: Simplify splithost by calling into urlparse. (#1849)

Browse source 
The current regex based splitting produces a wrong result. For example::

  http://abc#@def

Web browsers parse that URL as ``http://abc/#@def``, that is, the host
is ``abc``, the path is ``/``, and the fragment is ``#@def``.
This commit is contained in:
postmasters 2017-06-20 06:02:44 -07:00 • committed by Victor Stinner
parent 5cc7ac24da
commit 90e01e50ef
4 changed files with 47 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/urllib/parse.py
View file

@ -947,7 +947,7 @@ def splithost(url):
"""splithost('//host[:port]/path') --> 'host[:port]', '/path'."""
global _hostprog
if _hostprog is None:
_hostprog = re.compile('//([^/?]*)(.*)', re.DOTALL)
_hostprog = re.compile('//([^/#?]*)(.*)', re.DOTALL)
match = _hostprog.match(url)
if match: