mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-21 22:22:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-117657: Fix TSAN race in QSBR assertion (#119887)

Browse source 
Due to a limitation in TSAN, all reads from `PyThreadState.state` must be
atomic to avoid reported races.
This commit is contained in:
Sam Gross 2024-06-01 10:04:38 -04:00 • committed by GitHub
parent 60593b2052
commit 90ec19fd33
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Python/qsbr.c
View file

@ -160,7 +160,8 @@ qsbr_poll_scan(struct _qsbr_shared *shared)
bool
_Py_qsbr_poll(struct _qsbr_thread_state *qsbr, uint64_t goal)
{
assert(_PyThreadState_GET()->state == _Py_THREAD_ATTACHED);
assert(_Py_atomic_load_int_relaxed(&_PyThreadState_GET()->state) == _Py_THREAD_ATTACHED);
if (_Py_qbsr_goal_reached(qsbr, goal)) {
return true;
}