mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 10:19:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838)

Browse source 
(cherry picked from commit 369a1cbdee)

Co-authored-by: Victor Stinner <vstinner@python.org>
This commit is contained in:
Miss Islington (bot) 2020-08-12 06:13:09 -07:00 • committed by GitHub
parent 6e21a30215
commit 90eff4ed44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/codeop.py
View file

@ -84,9 +84,11 @@ def _maybe_compile(compiler, source, filename, symbol):
except SyntaxError: except SyntaxError:
pass pass
# Suppress warnings after the first compile to avoid duplication. # Catch syntax warnings after the first compile
# to emit SyntaxWarning at most once.
with warnings.catch_warnings(): with warnings.catch_warnings():
warnings.simplefilter("ignore") warnings.simplefilter("error", SyntaxWarning)
try: try:
code1 = compiler(source + "\n", filename, symbol) code1 = compiler(source + "\n", filename, symbol)
except SyntaxError as e: except SyntaxError as e:

7
Lib/test/test_codeop.py
View file

@ -4,6 +4,7 @@
""" """
import sys import sys
import unittest import unittest
import warnings
from test import support from test import support
from codeop import compile_command, PyCF_DONT_IMPLY_DEDENT from codeop import compile_command, PyCF_DONT_IMPLY_DEDENT
@ -309,5 +310,11 @@ class CodeopTests(unittest.TestCase):
compile_command("0 is 0") compile_command("0 is 0")
self.assertEqual(len(w.warnings), 1) self.assertEqual(len(w.warnings), 1)
# bpo-41520: check SyntaxWarning treated as an SyntaxError
with self.assertRaises(SyntaxError):
warnings.simplefilter('error', SyntaxWarning)
compile_command('1 is 1\n', symbol='exec')
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()

1
Misc/NEWS.d/next/Library/2020-08-12-13-25-16.bpo-41520.BEUWa4.rst Normal file
View file

@ -0,0 +1 @@
Fix :mod:`codeop` regression: it no longer ignores :exc:`SyntaxWarning`.