mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 10:19:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Add a note explaining why dict_update() doesn't use METH_FASTCALL

Browse source 
Issue #29312.
This commit is contained in:
Victor Stinner 2017-01-19 12:45:06 +01:00
parent 7dc6a5f50a
commit 91f0d4aa2f
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Objects/dictobject.c
View file

@ -2347,6 +2347,9 @@ dict_update_common(PyObject *self, PyObject *args, PyObject *kwds,
return result; return result;
} }
/* Note: dict.update() uses the METH_VARARGS|METH_KEYWORDS calling convention.
Using METH_FASTCALL would make dict.update(**dict2) calls slower, see the
issue #29312. */
static PyObject * static PyObject *
dict_update(PyObject *self, PyObject *args, PyObject *kwds) dict_update(PyObject *self, PyObject *args, PyObject *kwds)
{ {