mirror of
https://github.com/python/cpython.git
synced 2025-08-10 03:49:18 +00:00
[3.12] gh-113964: Don't prevent new threads until all non-daemon threads exit (GH-116677) (#117029)
Starting in Python 3.12, we prevented calling fork() and starting new threads
during interpreter finalization (shutdown). This has led to a number of
regressions and flaky tests. We should not prevent starting new threads
(or `fork()`) until all non-daemon threads exit and finalization starts in
earnest.
This changes the checks to use `_PyInterpreterState_GetFinalizing(interp)`,
which is set immediately before terminating non-daemon threads.
(cherry picked from commit 60e105c1c1
)
This commit is contained in:
parent
4be9fa8961
commit
92564331de
8 changed files with 57 additions and 27 deletions
|
@ -1190,7 +1190,7 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
|
|||
"thread is not supported for isolated subinterpreters");
|
||||
return NULL;
|
||||
}
|
||||
if (interp->finalizing) {
|
||||
if (_PyInterpreterState_GetFinalizing(interp) != NULL) {
|
||||
PyErr_SetString(PyExc_RuntimeError,
|
||||
"can't create new thread at interpreter shutdown");
|
||||
return NULL;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue