Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by Thomas

Jarosch.
This commit is contained in:
Charles-François Natali 2011-09-29 19:49:37 +02:00
commit 9624a764ff
3 changed files with 5 additions and 0 deletions

View file

@ -463,6 +463,7 @@ Bertrand Janin
Geert Jansen Geert Jansen
Jack Jansen Jack Jansen
Bill Janssen Bill Janssen
Thomas Jarosch
Julien Jehannet Julien Jehannet
Drew Jenkins Drew Jenkins
Flemming Kjær Jensen Flemming Kjær Jensen

View file

@ -1298,6 +1298,9 @@ Tools/Demos
Extension Modules Extension Modules
----------------- -----------------
- Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by
Thomas Jarosch.
- Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype. - Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.
Thanks to Suman Saha for finding the bug and providing a patch. Thanks to Suman Saha for finding the bug and providing a patch.

View file

@ -129,6 +129,7 @@ newossobject(PyObject *arg)
} }
if (ioctl(fd, SNDCTL_DSP_GETFMTS, &afmts) == -1) { if (ioctl(fd, SNDCTL_DSP_GETFMTS, &afmts) == -1) {
close(fd);
PyErr_SetFromErrnoWithFilename(PyExc_IOError, devicename); PyErr_SetFromErrnoWithFilename(PyExc_IOError, devicename);
return NULL; return NULL;
} }