mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #13211: Add .reason attribute to HTTPError to implement parent class (URLError) interface.

Browse source
This commit is contained in:
Jason R. Coombs 2011-11-07 10:44:25 -05:00
parent 49e49a218c
commit 974d863fec
2 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Lib/test/test_urllib2.py
View file

@ -1318,6 +1318,17 @@ class RequestTests(unittest.TestCase):
req = Request(url)
self.assertEqual(req.get_full_url(), url)
def test_HTTPError_interface():
"""
Issue 13211 reveals that HTTPError didn't implement the URLError
interface even though HTTPError is a subclass of URLError.
>>> err = urllib2.HTTPError(msg='something bad happened', url=None, code=None, hdrs=None, fp=None)
>>> assert hasattr(err, 'reason')
>>> err.reason
'something bad happened'
"""
def test_main(verbose=None):
from test import test_urllib2
test_support.run_doctest(test_urllib2, verbose)

6
Lib/urllib2.py
View file

@ -166,6 +166,12 @@ class HTTPError(URLError, addinfourl):
def __str__(self):
return 'HTTP Error %s: %s' % (self.code, self.msg)
# since URLError specifies a .reason attribute, HTTPError should also
# provide this attribute. See issue13211 fo discussion.
@property
def reason(self):
return self.msg
# copied from cookielib.py
_cut_port_re = re.compile(r":\d+$")
def request_host(request):