Fix issue #6973: When we know a subprocess.Popen process has died, do

not allow the send_signal(), terminate(), or kill() methods to do
anything as they could potentially signal a different process.

Lib/subprocess.py

@@ -1333,8 +1333,10 @@ class Popen(object):
             return (stdout, stderr)
 
         def send_signal(self, sig):
-            """Send a signal to the process
+            """Send a signal to the process."""
-            """
+            # Don't signal a process that we know has already died.
+            if self.returncode is not None:
+                return
             if sig == signal.SIGTERM:
                 self.terminate()
             elif sig == signal.CTRL_C_EVENT:
@@ -1345,8 +1347,10 @@ class Popen(object):
                 raise ValueError("Unsupported signal: {}".format(sig))
 
         def terminate(self):
-            """Terminates the process
+            """Terminates the process."""
-            """
+            # Don't terminate a process that we know has already died.
+            if self.returncode is not None:
+                return
             try:
                 _winapi.TerminateProcess(self._handle, 1)
             except PermissionError:
@@ -1754,8 +1758,9 @@ class Popen(object):
 
 
         def send_signal(self, sig):
-            """Send a signal to the process
+            """Send a signal to the process."""
-            """
+            # Skip signalling a process that we know has already died.
+            if self.returncode is None:
                 os.kill(self.pid, sig)
 
         def terminate(self):

Misc/NEWS

@@ -88,6 +88,10 @@ Core and Builtins
 Library
 -------
 
+- Issue #6973: When we know a subprocess.Popen process has died, do
+  not allow the send_signal(), terminate(), or kill() methods to do
+  anything as they could potentially signal a different process.
+
 - Issue #23883: Added missing APIs to __all__ to match the documented APIs
   for the following modules: csv, enum, ftplib, logging, optparse, threading
   and wave.  Also added a test.support.check__all__() helper.  Patches by