mirror of
https://github.com/python/cpython.git
synced 2025-08-04 00:48:58 +00:00
Fixed Issue1424152 in Py3k: urllib2 fails with HTTPS over Proxy.
This commit is contained in:
parent
be0e177ae5
commit
97f0c6be46
5 changed files with 68 additions and 3 deletions
|
@ -163,6 +163,7 @@ class Request:
|
|||
self.full_url = unwrap(url)
|
||||
self.data = data
|
||||
self.headers = {}
|
||||
self._tunnel_host = None
|
||||
for key, value in headers.items():
|
||||
self.add_header(key, value)
|
||||
self.unredirected_hdrs = {}
|
||||
|
@ -218,8 +219,12 @@ class Request:
|
|||
# End deprecated methods
|
||||
|
||||
def set_proxy(self, host, type):
|
||||
self.host, self.type = host, type
|
||||
self.selector = self.full_url
|
||||
if self.type == 'https' and not self._tunnel_host:
|
||||
self._tunnel_host = self.host
|
||||
else:
|
||||
self.type= type
|
||||
self.selector = self.full_url
|
||||
self.host = host
|
||||
|
||||
def has_proxy(self):
|
||||
return self.selector == self.full_url
|
||||
|
@ -659,7 +664,7 @@ class ProxyHandler(BaseHandler):
|
|||
req.add_header('Proxy-authorization', 'Basic ' + creds)
|
||||
hostport = unquote(hostport)
|
||||
req.set_proxy(hostport, proxy_type)
|
||||
if orig_type == proxy_type:
|
||||
if orig_type == proxy_type or orig_type == 'https':
|
||||
# let other handlers take care of it
|
||||
return None
|
||||
else:
|
||||
|
@ -1041,6 +1046,10 @@ class AbstractHTTPHandler(BaseHandler):
|
|||
# request.
|
||||
headers["Connection"] = "close"
|
||||
headers = dict((name.title(), val) for name, val in headers.items())
|
||||
|
||||
if req._tunnel_host:
|
||||
h.set_tunnel(req._tunnel_host)
|
||||
|
||||
try:
|
||||
h.request(req.get_method(), req.selector, req.data, headers)
|
||||
r = h.getresponse() # an HTTPResponse instance
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue