mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-12 13:55:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

bpo-19466: Py_Finalize() clears daemon threads earlier (GH-18848)

Browse source 
Clear the frames of daemon threads earlier during the Python shutdown to
call objects destructors. So "unclosed file" resource warnings are now
emitted for daemon threads in a more reliable way.

Cleanup _PyThreadState_DeleteExcept() code: rename "garbage" to
"list".
This commit is contained in:
Victor Stinner 2020-03-09 23:37:49 +01:00 • committed by GitHub
parent 8e9c47a947
commit 9ad58acbe8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 70 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Python/pylifecycle.c
View file

@ -1373,6 +1373,16 @@ Py_FinalizeEx(void)
runtime->initialized = 0;
runtime->core_initialized = 0;
/* Destroy the state of all threads of the interpreter, except of the
current thread. In practice, only daemon threads should still be alive,
except if wait_for_thread_shutdown() has been cancelled by CTRL+C.
Clear frames of other threads to call objects destructors. Destructors
will be called in the current Python thread. Since
_PyRuntimeState_SetFinalizing() has been called, no other Python thread
can take the GIL at this point: if they try, they will exit
immediately. */
_PyThreadState_DeleteExcept(runtime, tstate);
/* Flush sys.stdout and sys.stderr */
if (flush_std_files() < 0) {
status = -1;