mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

asyncio: Make Semaphore(0) work properly.

Browse source
This commit is contained in:
Guido van Rossum 2013-11-21 11:07:45 -08:00
parent d88c6f9b9b
commit 9c55a58a1d
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/asyncio/locks.py
View file

@ -348,12 +348,12 @@ class Semaphore:
def __init__(self, value=1, bound=False, *, loop=None): def __init__(self, value=1, bound=False, *, loop=None):
if value < 0: if value < 0:
raise ValueError("Semaphore initial value must be > 0") raise ValueError("Semaphore initial value must be >= 0")
self._value = value self._value = value
self._bound = bound self._bound = bound
self._bound_value = value self._bound_value = value
self._waiters = collections.deque() self._waiters = collections.deque()
self._locked = False self._locked = (value == 0)
if loop is not None: if loop is not None:
self._loop = loop self._loop = loop
else: else:

4
Lib/test/test_asyncio/test_locks.py
View file

@ -684,6 +684,10 @@ class SemaphoreTests(unittest.TestCase):
finally: finally:
events.set_event_loop(None) events.set_event_loop(None)
def test_initial_value_zero(self):
sem = locks.Semaphore(0, loop=self.loop)
self.assertTrue(sem.locked())
def test_repr(self): def test_repr(self):
sem = locks.Semaphore(loop=self.loop) sem = locks.Semaphore(loop=self.loop)
self.assertTrue(repr(sem).endswith('[unlocked,value:1]>')) self.assertTrue(repr(sem).endswith('[unlocked,value:1]>'))