mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-29 06:05:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Fix-up signature for approximation.

Browse source
This commit is contained in:
Raymond Hettinger 2008-01-25 01:23:38 +00:00
parent 7ea82253ea
commit 9c6d81f5dd
2 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Lib/rational.py
View file

@ -195,16 +195,17 @@ class Rational(RationalAbc):
n, d = d, n
return cf
@classmethod
def approximate_from_float(cls, f, max_denominator):
'Best rational approximation to f with a denominator <= max_denominator'
def approximate(self, max_denominator):
'Best rational approximation with a denominator <= max_denominator'
# XXX First cut at algorithm
# Still needs rounding rules as specified at
# http://en.wikipedia.org/wiki/Continued_fraction
cf = cls.from_float(f).as_continued_fraction()
if self.denominator <= max_denominator:
return self
cf = self.as_continued_fraction()
result = Rational(0)
for i in range(1, len(cf)):
new = cls.from_continued_fraction(cf[:i])
new = self.from_continued_fraction(cf[:i])
if new.denominator > max_denominator:
break
result = new