mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Revert "bpo-46110: Add a recursion check to avoid stack overflow in the PEG parser (GH-30177)" (GH-30363)

Browse source 
This reverts commit e9898bf153 temporarily as we want to confirm if this commit is the cause of a slowdown at startup time.
This commit is contained in:
Pablo Galindo Salgado 2022-01-03 18:29:18 +00:00 • committed by GitHub
parent c960b191b8
commit 9d35dedc5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 3197 additions and 4602 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tools/peg_generator/pegen/c_generator.py
View file

@ -37,8 +37,6 @@ EXTENSION_PREFIX = """\
# define D(x)
#endif
# define MAXSTACK 6000
"""
@ -366,14 +364,10 @@ class CParserGenerator(ParserGenerator, GrammarVisitor):
self.skip_actions = skip_actions
def add_level(self) -> None:
self.print("if (p->level++ == MAXSTACK) {")
with self.indent():
self.print("p->error_indicator = 1;")
self.print("PyErr_NoMemory();")
self.print("}")
self.print("D(p->level++);")
def remove_level(self) -> None:
self.print("p->level--;")
self.print("D(p->level--);")
def add_return(self, ret_val: str) -> None:
self.remove_level()
@ -550,10 +544,9 @@ class CParserGenerator(ParserGenerator, GrammarVisitor):
self.print("p->in_raw_rule++;")
self.print(f"void *_raw = {node.name}_raw(p);")
self.print("p->in_raw_rule--;")
self.print("if (p->error_indicator) {")
self.print("if (p->error_indicator)")
with self.indent():
self.add_return("NULL")
self.print("}")
self.print("return NULL;")
self.print("if (_raw == NULL || p->mark <= _resmark)")
with self.indent():
self.print("break;")