mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-96577: Fixes buffer overrun in _msi module (GH-96633)

Browse source 
(cherry picked from commit 4114bcc9ef)

Co-authored-by: Steve Dower <steve.dower@python.org>
This commit is contained in:
Miss Islington (bot) 2022-09-07 12:46:09 -07:00 • committed by GitHub
parent 295f510f5a
commit 9fa21d050a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Windows/2022-09-07-00-11-33.gh-issue-96577.kV4K_1.rst Normal file
View file

@ -0,0 +1 @@
Fixes a potential buffer overrun in :mod:`msilib`.

4
PC/_msi.c
View file

@ -360,7 +360,7 @@ msierror(int status)
int code;
char buf[2000];
char *res = buf;
DWORD size = sizeof(buf);
DWORD size = Py_ARRAY_LENGTH(buf);
MSIHANDLE err = MsiGetLastErrorRecord();
if (err == 0) {
@ -484,7 +484,7 @@ _msi_Record_GetString_impl(msiobj *self, unsigned int field)
unsigned int status;
WCHAR buf[2000];
WCHAR *res = buf;
DWORD size = sizeof(buf);
DWORD size = Py_ARRAY_LENGTH(buf);
PyObject* string;
status = MsiRecordGetStringW(self->h, field, res, &size);