mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679)

Browse source 
The call to `with self.subTest(...)` was not thread-safe.
This commit is contained in:
Sam Gross 2025-03-24 16:41:50 -04:00 • committed by GitHub
parent 7c3692fe27
commit a123245986
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_functools.py
View file

@ -1934,8 +1934,7 @@ class TestLRU:
time.sleep(.01) time.sleep(.01)
return 3 * x return 3 * x
def test(i, x): def test(i, x):
with self.subTest(thread=i): self.assertEqual(f(x), 3 * x, i)
self.assertEqual(f(x), 3 * x, i)
threads = [threading.Thread(target=test, args=(i, v)) threads = [threading.Thread(target=test, args=(i, v))
for i, v in enumerate([1, 2, 2, 3, 2])] for i, v in enumerate([1, 2, 2, 3, 2])]
with threading_helper.start_threads(threads): with threading_helper.start_threads(threads):