bpo-32604: [_xxsubinterpreters] Propagate exceptions. (GH-19768)

Browse source

(Note: PEP 554 is not accepted and the implementation in the code base is a private one for use in the test suite.)

If code running in a subinterpreter raises an uncaught exception then the "run" call in the calling interpreter fails. A RunFailedError is raised there that summarizes the original exception as a string. The actual exception type, __cause__, __context__, state, etc. are all discarded. This turned out to be functionally insufficient in practice. There is a more helpful solution (and PEP 554 has been updated appropriately).

This change adds the exception propagation behavior described in PEP 554 to the _xxsubinterpreters module. With this change a copy of the original exception is set to __cause__ on the RunFailedError. For now we are using "pickle", which preserves the exception's state. We also preserve the original __cause__, __context__, and __traceback__ (since "pickle" does not preserve those).

https://bugs.python.org/issue32604

...

This commit is contained in:

Eric Snow 2020-05-07 08:56:01 -06:00 • committed by GitHub

parent 8963a7f1f8

commit a1d9e0accd

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

2 changed files with 1324 additions and 130 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1153

Modules/_xxsubinterpretersmodule.c

View file

File diff suppressed because it is too large Load diff