mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-19 15:10:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-116325: Raise SyntaxError rather than IndexError on ForwardRef with empty string arg (#116341)

Browse source
This commit is contained in:
Nikita Sobolev 2024-03-05 12:14:18 +03:00 • committed by GitHub
parent ffcc450a9b
commit a29998a06b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/test/test_typing.py
View file

@ -5867,6 +5867,12 @@ class ForwardRefTests(BaseTestCase):
with self.assertRaises(SyntaxError): with self.assertRaises(SyntaxError):
get_type_hints(foo) get_type_hints(foo)
def test_syntax_error_empty_string(self):
for form in [typing.List, typing.Set, typing.Type, typing.Deque]:
with self.subTest(form=form):
with self.assertRaises(SyntaxError):
form['']
def test_name_error(self): def test_name_error(self):
def foo(a: 'Noode[T]'): def foo(a: 'Noode[T]'):

2
Lib/typing.py
View file

@ -880,7 +880,7 @@ class ForwardRef(_Final, _root=True):
# If we do `def f(*args: *Ts)`, then we'll have `arg = '*Ts'`. # If we do `def f(*args: *Ts)`, then we'll have `arg = '*Ts'`.
# Unfortunately, this isn't a valid expression on its own, so we # Unfortunately, this isn't a valid expression on its own, so we
# do the unpacking manually. # do the unpacking manually.
if arg[0] == '*': if arg.startswith('*'):
arg_to_compile = f'({arg},)[0]' # E.g. (*Ts,)[0] or (*tuple[int, int],)[0] arg_to_compile = f'({arg},)[0]' # E.g. (*Ts,)[0] or (*tuple[int, int],)[0]
else: else:
arg_to_compile = arg arg_to_compile = arg

2
Misc/NEWS.d/next/Library/2024-03-05-02-09-18.gh-issue-116325.FmlBYv.rst Normal file
View file

@ -0,0 +1,2 @@
:mod:`typing`: raise :exc:`SyntaxError` instead of :exc:`AttributeError`
on forward references as empty strings.