mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-14 04:37:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Fix for the unfortunate fact that PyDict_GetItem and PyObject_GetItem

Browse source 
have differing refcount semantics.  If anyone sees a prettier way to
acheive the same ends, then please go for it.

I think this is the first time I've ever used Py_XINCREF.
This commit is contained in:
Michael W. Hudson 2004-08-02 14:50:43 +00:00
parent 77a602fbf2
commit a3711f73c1
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Python/ceval.c
View file

@ -1742,8 +1742,10 @@ PyEval_EvalFrame(PyFrameObject *f)
PyObject_REPR(w)); PyObject_REPR(w));
break; break;
} }
if (PyDict_CheckExact(v)) if (PyDict_CheckExact(v)) {
x = PyDict_GetItem(v, w); x = PyDict_GetItem(v, w);
Py_XINCREF(x);
}
else { else {
x = PyObject_GetItem(v, w); x = PyObject_GetItem(v, w);
if (x == NULL && PyErr_Occurred()) { if (x == NULL && PyErr_Occurred()) {
@ -1763,8 +1765,8 @@ PyEval_EvalFrame(PyFrameObject *f)
break; break;
} }
} }
Py_INCREF(x);
} }
Py_INCREF(x);
PUSH(x); PUSH(x);
continue; continue;