mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #11014: Make 'filter' argument in tarfile.Tarfile.add() into a

Browse source 
keyword-only argument.  The preceding positional argument was deprecated,
so it made no sense to add filter as a positional argument.

(Patch reviewed by Brian Curtin and Anthony Long.)
This commit is contained in:
Raymond Hettinger 2011-01-26 20:34:14 +00:00
parent e3b8f7c0fa
commit a63a312a3f
4 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/test_tarfile.py
View file

@ -919,6 +919,10 @@ class WriteTest(WriteTestBase):
finally:
tar.close()
# Verify that filter is a keyword-only argument
with self.assertRaises(TypeError):
tar.add(tempdir, "empty_dir", True, None, filter)
tar = tarfile.open(tmpname, "r")
try:
for tarinfo in tar: