mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #24347: Set KeyError if PyDict_GetItemWithError returns NULL.

Browse source
This commit is contained in:
Eric Snow 2015-06-01 22:59:08 -06:00
parent fa1b47cc5a
commit a762af74b2
4 changed files with 69 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Lib/test/test_collections.py
View file

@ -2037,6 +2037,24 @@ class CPythonOrderedDictTests(OrderedDictTests, unittest.TestCase):
del od[colliding]
self.assertEqual(list(od.items()), [(key, ...), ('after', ...)])
def test_issue24347(self):
OrderedDict = self.module.OrderedDict
class Key:
def __hash__(self):
return randrange(100000)
od = OrderedDict()
for i in range(100):
key = Key()
od[key] = i
# These should not crash.
with self.assertRaises(KeyError):
repr(od)
with self.assertRaises(KeyError):
od.copy()
class PurePythonGeneralMappingTests(mapping_tests.BasicTestMappingProtocol):