mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-04 00:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #25583: Avoid incorrect errors raised by os.makedirs(exist_ok=True)

Browse source
This commit is contained in:
Martin Panter 2015-11-19 04:48:44 +00:00
parent 41f69f4cc7
commit a82642f9db
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/os.py
View file

@ -226,7 +226,7 @@ def makedirs(name, mode=0o777, exist_ok=False):
try:
makedirs(head, mode, exist_ok)
except FileExistsError:
# be happy if someone already created the path
# Defeats race condition when another thread created the path
pass
cdir = curdir
if isinstance(tail, bytes):
@ -235,8 +235,10 @@ def makedirs(name, mode=0o777, exist_ok=False):
return
try:
mkdir(name, mode)
except OSError as e:
if not exist_ok or e.errno != errno.EEXIST or not path.isdir(name):
except OSError:
# Cannot rely on checking for EEXIST, since the operating system
# could give priority to other errors like EACCES or EROFS
if not exist_ok or not path.isdir(name):
raise
def removedirs(name):