mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 11:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-97669: Fix test_tools reference leak (#98216)

Browse source 
test_tools.test_sundry() now uses an unittest mock to prevent the
logging module to register a real "atfork" function which kept the
logging module dictionary alive. So the logging module can be
properly unloaded. Previously, the logging module was loaded before
test_sundry(), but it's no longer the case since recent test_tools
sub-tests removals.
This commit is contained in:
Victor Stinner 2022-10-12 17:26:21 +02:00 • committed by GitHub
parent 0895c2a066
commit a8c8526fd8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/test/test_tools/test_sundry.py
View file

@ -27,7 +27,11 @@ class TestSundryScripts(unittest.TestCase):
skiplist = denylist + allowlist + other
def test_sundry(self):
# import logging registers "atfork" functions which keep indirectly the
# logging module dictionary alive. Mock the function to be able to unload
# cleanly the logging module.
@import_helper.mock_register_at_fork
def test_sundry(self, mock_os):
old_modules = import_helper.modules_setup()
try:
for fn in os.listdir(scriptsdir):